Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "Qwik City" to "Qwik Router" #7008

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Rename "Qwik City" to "Qwik Router" #7008

merged 1 commit into from
Oct 29, 2024
+5,459 −4,464

Conversation

shairez
Copy link
Contributor

@shairez shairez commented Oct 28, 2024

Description

Here's the context for this change:

QwikDev/qwik-evolution#186

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@shairez shairez requested review from a team as code owners October 28, 2024 20:45
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: efb2d0d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@shairez shairez mentioned this pull request Oct 28, 2024
Open
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 28, 2024

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7008

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7008

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7008

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7008

commit: efb2d0d

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview efb2d0d

@shairez shairez self-assigned this Oct 28, 2024
wmertens
wmertens approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PatrickJS
Copy link
Member

finally a router

gioboa
gioboa approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shairez

@shairez shairez merged commit 3e21dd9 into build/v2 Oct 29, 2024
22 checks passed
@shairez shairez deleted the pr-rename-city-to-router branch October 29, 2024 09:23
@github-actions github-actions bot mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens wmertens approved these changes

@PatrickJS PatrickJS PatrickJS approved these changes

@gioboa gioboa gioboa approved these changes

@Varixo Varixo Varixo approved these changes

Assignees

@shairez shairez

Labels
None yet
Projects
Qwik Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shairez @PatrickJS @wmertens @gioboa @Varixo